Messages in this thread | ![/](/images/icornerl.gif) | | From | Trevor Gross <> | Date | Wed, 31 Jan 2024 16:45:29 -0500 | Subject | Re: [PATCH v1] rust: add reexports for macros |
| |
On Mon, Jan 29, 2024 at 9:58 AM Alice Ryhl <aliceryhl@google.com> wrote: > > Currently, all macros are reexported with #[macro_export] only, which > means that to access `new_work!` from the workqueue, you need to import > it from the path `kernel::new_work` instead of importing it from the > workqueue module like all other items in the workqueue. By adding > reexports of the macros, it becomes possible to import the macros from > the correct modules. > > It's still possible to import the macros from the root, but I don't > think we can do anything about that. > > There is no functional change. This is merely a code cleanliness > improvement. > > Signed-off-by: Alice Ryhl <aliceryhl@google.com> > ---
Reviewed-by: Trevor Gross <tmgross@umich.edu>
| ![\](/images/icornerr.gif) |