lkml.org 
[lkml]   [2024]   [Jan]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2] arm64: dts: mt8183: jacuzzi: Remove CrosEC base detection node
Quoting Nícolas F. R. A. Prado (2024-01-12 06:20:28)
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi
> index 7592e3b86037..8c9f7435cf4c 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi
> @@ -484,3 +484,6 @@ volup-btn-odl {
> };
> };
>
> +&cros_ec {
> + /delete-node/ cbas;
> +};

Usually we add nodes instead of delete them. Can you move the cbas node
addition to the other files that include mt8183-kukui.dtsi instead? It
will be a larger patch in number of lines but then we don't run into
problems where the node is moved later and this breaks because 'cbas'
doesn't exist.

\
 
 \ /
  Last update: 2024-01-12 23:46    [W:0.039 / U:0.348 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site