Messages in this thread | | | From | Linus Walleij <> | Date | Thu, 11 Jan 2024 15:22:59 +0100 | Subject | Re: [PATCH 1/2] gpio: vf610: add support to DT 'ngpios' property |
| |
On Thu, Jan 11, 2024 at 2:20 PM Hector Palacios <hector.palacios@digi.com> wrote:
> Default to hardcoded VF610_GPIO_PER_PORT (32 pins) but allow optional > generic 'ngpios' property to be specified from the device tree. > > Signed-off-by: Hector Palacios <hector.palacios@digi.com>
Looks correct to me. Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
NB: this only makes sense when you use GPIOs 0...n where n < 31.
We also have the .valid_mask and .init_valid_mask() callback if you want to mask out GPIOs in the middle or beginning or so.
Yours, Linus Walleij
Yours, Linus Walleij
| |