Messages in this thread | | | Date | Thu, 11 Jan 2024 09:16:01 +0100 | From | neil.armstrong@linaro ... | Subject | Re: [PATCH v1 17/24] arch: arm64: dts: meson: a1: add crypto node |
| |
On 10/01/2024 21:11, Alexey Romanov wrote: > This patch adds a crypto node declaration. With the > Amlogic crypto driver we can use HW implementation > of SHA1/224/256 and AES algo. > > Signed-off-by: Alexey Romanov <avromanov@salutedevices.com> > --- > arch/arm64/boot/dts/amlogic/meson-a1.dtsi | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi > index cf150f568335..879e0ce0b2ea 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi > @@ -653,6 +653,14 @@ sd_emmc: sd@10000 { > power-domains = <&pwrc PWRC_SD_EMMC_ID>; > status = "disabled"; > }; > + > + crypto: crypto@6000 { > + compatible = "amlogic,g12a-crypto"; > + reg = <0x0 0x6000 0x0 0x48>; > + interrupts = <GIC_SPI 120 IRQ_TYPE_EDGE_RISING>; > + power-domains = <&pwrc PWRC_DMA_ID>; > + status = "disabled";
Why disabled ? Usually we always leave the embedded HW enabled by default.
The comment is valid for the other dtsi changes,
Neil
> + }; > }; > > usb: usb@fe004400 {
| |