lkml.org 
[lkml]   [2023]   [Sep]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] mfd: cs42l43: fix defined but not used warnings
Date
From: Shida Zhang <zhangshida@kylinos.cn>

Warnings were generated during compiling for functions like
cs42l43_*_{resume,suspend}:

../drivers/mfd/cs42l43.c:1138:12: error: ‘cs42l43_runtime_resume’ defined but not used [-Werror=unused-function]
1138 | static int cs42l43_runtime_resume(struct device *dev)
| ^~~~~~~~~~~~~~~~~~~~~~
../drivers/mfd/cs42l43.c:1124:12: error: ‘cs42l43_runtime_suspend’ defined but not used [-Werror=unused-function]
1124 | static int cs42l43_runtime_suspend(struct device *dev)
| ^~~~~~~~~~~~~~~~~~~~~~~
../drivers/mfd/cs42l43.c:1106:12: error: ‘cs42l43_resume’ defined but not used [-Werror=unused-function]
1106 | static int cs42l43_resume(struct device *dev)
| ^~~~~~~~~~~~~~
../drivers/mfd/cs42l43.c:1076:12: error: ‘cs42l43_suspend’ defined but not used [-Werror=unused-function]
1076 | static int cs42l43_suspend(struct device *dev)

Fix it by guarding it with CONFIG_PM/CONFIG_PM_SLEEP.

Reported-by: k2ci <kernel-bot@kylinos.cn>
Signed-off-by: Shida Zhang <zhangshida@kylinos.cn>
---
drivers/mfd/cs42l43.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/drivers/mfd/cs42l43.c b/drivers/mfd/cs42l43.c
index 37b23e9bae82..e589a61c118d 100644
--- a/drivers/mfd/cs42l43.c
+++ b/drivers/mfd/cs42l43.c
@@ -1073,6 +1073,7 @@ void cs42l43_dev_remove(struct cs42l43 *cs42l43)
}
EXPORT_SYMBOL_NS_GPL(cs42l43_dev_remove, MFD_CS42L43);

+#ifdef CONFIG_PM_SLEEP
static int cs42l43_suspend(struct device *dev)
{
struct cs42l43 *cs42l43 = dev_get_drvdata(dev);
@@ -1120,7 +1121,9 @@ static int cs42l43_resume(struct device *dev)

return 0;
}
+#endif

+#ifdef CONFIG_PM
static int cs42l43_runtime_suspend(struct device *dev)
{
struct cs42l43 *cs42l43 = dev_get_drvdata(dev);
@@ -1176,6 +1179,7 @@ static int cs42l43_runtime_resume(struct device *dev)

return ret;
}
+#endif

EXPORT_NS_GPL_DEV_PM_OPS(cs42l43_pm_ops, MFD_CS42L43) = {
SET_SYSTEM_SLEEP_PM_OPS(cs42l43_suspend, cs42l43_resume)
--
2.27.0
\
 
 \ /
  Last update: 2023-09-05 18:05    [W:0.204 / U:0.436 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site