Messages in this thread | | | Date | Tue, 5 Sep 2023 10:28:06 +0300 | Subject | Re: [PATCH 3/4] drm/bridge: lt8912b: Manually disable HPD only if it was enabled | From | Tomi Valkeinen <> |
| |
On 04/09/2023 21:08, Marcel Ziswiler wrote: > Hi Tomi > > Looks good. Thanks! Tested both on Verdin AM62 as well as on Verdin iMX8M Mini. > > Just a minor nit-pick in your commit message. > > On Fri, 2023-08-04 at 13:48 +0300, Tomi Valkeinen wrote: >> lt8912b only calls drm_bridge_hpd_enable() if it creates a connector and >> the next bridge has DRM_BRIDGE_OP_HPD set. However, when calling >> drm_bridge_hpd_disable() it misses checking if a connector was created, >> calling drm_bridge_hpd_disable() even if HPD was nenver enabled. I don't > > was never enabled > >> see any issues causing by this wrong call, though. > > any issues caused by this wrong call > >> Add the check to avoid wrongly calling drm_bridge_hpd_disable(). >> >> Fixes: 3b0a01a6a522 ("drm/bridge: lt8912b: Add hot plug detection") >> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> > > For the whole series: > > Tested-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
Thanks! I have fixed the typos in the desc.
Tomi
| |