lkml.org 
[lkml]   [2023]   [Sep]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH] gfs2: fix 'passing zero to ERR_PTR()' warning
Resolve the following Smatch static checker warning:
fs/gfs2/acl.c:54 __gfs2_get_acl() warn: passing zero to 'ERR_PTR'

by returning NULL when an extended attribute length is zero, instead of
passing on zero to the ERR_PTR().

Signed-off-by: Deepak R Varma <drv@mailo.com>
---
Please note: Patch is build tested only.


fs/gfs2/acl.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/fs/gfs2/acl.c b/fs/gfs2/acl.c
index 443640e6fb9c..818d67f10dcf 100644
--- a/fs/gfs2/acl.c
+++ b/fs/gfs2/acl.c
@@ -50,8 +50,11 @@ static struct posix_acl *__gfs2_get_acl(struct inode *inode, int type)

name = gfs2_acl_name(type);
len = gfs2_xattr_acl_get(ip, name, &data);
- if (len <= 0)
+ if (len == 0)
+ return NULL;
+ if (len < 0)
return ERR_PTR(len);
+
acl = posix_acl_from_xattr(&init_user_ns, data, len);
kfree(data);
return acl;
--
2.39.2


\
 
 \ /
  Last update: 2023-09-28 20:08    [W:0.967 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site