| From | Vladimir Oltean <> | Subject | [RFC PATCH v2 net-next 10/15] net: phylink: support all ethtool port modes with inband modes | Date | Sat, 23 Sep 2023 16:48:59 +0300 |
| |
Currently, phylink_parse_mode() filters out all port modes except ETHTOOL_LINK_MODE_MII_BIT for in-band link modes. But if we're going to accept backplane port modes with inband autoneg, then we should also allow ETHTOOL_LINK_MODE_Backplane_BIT.
Use phylink_set_port_modes() to just allow them all, and let the validate() functions of the MAC and phylink_pcs restrict what they don't support.
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> --- v1->v2: patch is new
drivers/net/phy/phylink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c index 88ace7e203c3..6415c7b91053 100644 --- a/drivers/net/phy/phylink.c +++ b/drivers/net/phy/phylink.c @@ -880,7 +880,7 @@ static int phylink_parse_mode(struct phylink *pl, } linkmode_zero(pl->supported); - phylink_set(pl->supported, MII); + phylink_set_port_modes(pl->supported); phylink_set(pl->supported, Autoneg); phylink_set(pl->supported, Asym_Pause); phylink_set(pl->supported, Pause); -- 2.34.1
|