lkml.org 
[lkml]   [2023]   [Sep]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC PATCH v2 net-next 03/15] phy: ethernet: add configuration interface for copper backplane Ethernet PHYs
    On Sat, Sep 23, 2023 at 04:48:52PM +0300, Vladimir Oltean wrote:

    ...

    > +/**
    > + * coef_update_opposite - return the opposite of one C72 coefficient update
    > + * request
    > + *
    > + * @update: original coefficient update
    > + *
    > + * Helper to transform the update request of one equalization tap into a
    > + * request of the same tap in the opposite direction. May be used by C72
    > + * phy remote TX link training algorithms.
    > + */
    > +static inline enum coef_update coef_update_opposite(enum coef_update update)

    Hi Vladimir,

    another nit from me.

    Please put the inline keyword first.
    Likewise elsewhere in this patch.

    Tooling, including gcc-13 with W=1, complains about this.

    > +{
    > + switch (update) {
    > + case COEF_UPD_INC:
    > + return COEF_UPD_DEC;
    > + case COEF_UPD_DEC:
    > + return COEF_UPD_INC;
    > + default:
    > + return COEF_UPD_HOLD;
    > + }
    > +}

    ...

    \
     
     \ /
      Last update: 2023-09-28 21:07    [W:5.181 / U:0.400 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site