lkml.org 
[lkml]   [2023]   [Sep]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch V3 20/30] x86/microcode: Sanitize __wait_for_cpus()
On Tue, Sep 12, 2023 at 09:58:15AM +0200, Thomas Gleixner wrote:
> + for (timeout = 0; timeout < USEC_PER_SEC; timeout++) {
> + if (!atomic_read(cnt))
> + return true;

<---- newline here.

> + udelay(1);

And here.

Otherwise it looks too crammed.

> + if (!(timeout % 1000))

MSEC_PER_SEC - no naked numbers pls.

> + touch_nmi_watchdog();
> }
> - return 0;
> + /* Prevent the late comers to make progress and let them time out */

s/to make progress/from making progress/

Nice, otherwise.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette

\
 
 \ /
  Last update: 2023-09-22 18:25    [W:0.886 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site