| Date | Fri, 22 Sep 2023 18:24:29 +0200 | From | Borislav Petkov <> | Subject | Re: [patch V3 20/30] x86/microcode: Sanitize __wait_for_cpus() |
| |
On Tue, Sep 12, 2023 at 09:58:15AM +0200, Thomas Gleixner wrote: > + for (timeout = 0; timeout < USEC_PER_SEC; timeout++) { > + if (!atomic_read(cnt)) > + return true;
<---- newline here.
> + udelay(1);
And here.
Otherwise it looks too crammed.
> + if (!(timeout % 1000))
MSEC_PER_SEC - no naked numbers pls.
> + touch_nmi_watchdog(); > } > - return 0; > + /* Prevent the late comers to make progress and let them time out */
s/to make progress/from making progress/
Nice, otherwise.
-- Regards/Gruss, Boris.
https://people.kernel.org/tglx/notes-about-netiquette
|