Messages in this thread | | | Date | Mon, 18 Sep 2023 16:55:56 +0200 (CEST) | From | Jiri Kosina <> | Subject | Re: [PATCH] HID: nvidia-shield: add LEDS_CLASS dependency |
| |
On Wed, 13 Sep 2023, Randy Dunlap wrote:
> The hid-nvidia-shield driver uses functions that are built > only when LEDS_CLASS is set, so make the driver depend on that > symbol to prevent build errors. > > riscv32-linux-ld: drivers/hid/hid-nvidia-shield.o: in function `.L11': > hid-nvidia-shield.c:(.text+0x192): undefined reference to `led_classdev_unregister' > riscv32-linux-ld: drivers/hid/hid-nvidia-shield.o: in function `.L113': > hid-nvidia-shield.c:(.text+0xfa4): undefined reference to `led_classdev_register_ext' > > Fixes: 09308562d4af ("HID: nvidia-shield: Initial driver implementation with Thunderstrike support") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: Rahul Rameshbabu <rrameshbabu@nvidia.com> > Cc: Jiri Kosina <jkosina@suse.cz> > Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com> > Cc: linux-input@vger.kernel.org > --- > drivers/hid/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff -- a/drivers/hid/Kconfig b/drivers/hid/Kconfig > --- a/drivers/hid/Kconfig > +++ b/drivers/hid/Kconfig > @@ -799,6 +799,7 @@ config HID_NVIDIA_SHIELD > tristate "NVIDIA SHIELD devices" > depends on USB_HID > depends on BT_HIDP > + depends on LEDS_CLASS
Aplied, thanks.
-- Jiri Kosina SUSE Labs
| |