lkml.org 
[lkml]   [2023]   [Sep]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/3] riscv: Improve PTDUMP to show RSW with non-zero value
On Thu, Sep 14, 2023 at 09:40:25AM +0800, Yu Chien Peter Lin wrote:

> + val = st->current_prot & pte_bits[i].mask;
> + if (val) {
> + if (pte_bits[i].mask == _PAGE_SOFT)
> + sprintf(s, pte_bits[i].set, val >> 8);
> + else
> + sprintf(s, "%s", pte_bits[i].set);
> + } else
> + sprintf(s, "%s", pte_bits[i].clear);
> +

just a nit, but checkpatch in the automation is whinging that you have
forgotten to add {} around both branches if this if statement.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2023-09-18 14:55    [W:0.031 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site