lkml.org 
[lkml]   [2023]   [Sep]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH v2] mm/damon/core: remove unnecessary si_meminfo invoke.
Date
si_meminfo() will read and assign more info not just free/ram pages.
For just DAMOS_WMARK_FREE_MEM_RATE use, only get free and ram pages
is ok to save cpu.

Change from v1:
v1 fold free mem rate logic into __damos_get_wmark_free_mem_rate and not
invoke si_meminfo, just get free/ram_pages in global.
v2 cancel this __damos_get_wmark_free_mem_rate and just calculate rate
in damos_wmark_metric_value to keep it simple.

Signed-off-by: Huan Yang <link@vivo.com>
---
mm/damon/core.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/mm/damon/core.c b/mm/damon/core.c
index bcd2bd9d6c10..a3f812d78267 100644
--- a/mm/damon/core.c
+++ b/mm/damon/core.c
@@ -1280,12 +1280,9 @@ static bool kdamond_need_stop(struct damon_ctx *ctx)

static unsigned long damos_wmark_metric_value(enum damos_wmark_metric metric)
{
- struct sysinfo i;
-
switch (metric) {
case DAMOS_WMARK_FREE_MEM_RATE:
- si_meminfo(&i);
- return i.freeram * 1000 / i.totalram;
+ return global_zone_page_state(NR_FREE_PAGES) * 1000 / totalram_pages();
default:
break;
}
--
2.34.1
\
 
 \ /
  Last update: 2023-09-19 04:02    [W:0.041 / U:0.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site