lkml.org 
[lkml]   [2023]   [Sep]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [RFC PATCH v2 05/35] drivers: base: Print a warning instead of panic() when register_cpu() fails
From


On 9/14/23 02:37, James Morse wrote:
> loongarch, mips, parisc, riscv and sh all print a warning if
> register_cpu() returns an error. Architectures that use
> GENERIC_CPU_DEVICES call panic() instead.
>
> Errors in this path indicate something is wrong with the firmware
> description of the platform, but the kernel is able to keep running.
>
> Downgrade this to a warning to make it easier to debug this issue.
>
> This will allow architectures that switching over to GENERIC_CPU_DEVICES
> to drop their warning, but keep the existing behaviour.
>
> Signed-off-by: James Morse <james.morse@arm.com>
> ---
> drivers/base/cpu.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/base/cpu.c b/drivers/base/cpu.c
> index 579064fda97b..d31c936f0955 100644
> --- a/drivers/base/cpu.c
> +++ b/drivers/base/cpu.c
> @@ -535,14 +535,15 @@ int __weak arch_register_cpu(int cpu)
>
> static void __init cpu_dev_register_generic(void)
> {
> - int i;
> + int i, ret;
>
> if (!IS_ENABLED(CONFIG_GENERIC_CPU_DEVICES))
> return;
>
> for_each_present_cpu(i) {
> - if (arch_register_cpu(i))
> - panic("Failed to register CPU device");
> + ret = arch_register_cpu(i);
> + if (ret)
> + pr_warn("register_cpu %d failed (%d)\n", i, ret);
> }
> }
>

The same warning message has been printed by arch/loongarch/kernel/topology.c::arch_register_cpu().
In order to avoid the duplication, I think the warning message in arch/loongarch needs to be dropped?

Thanks,
Gavin

\
 
 \ /
  Last update: 2023-09-18 05:36    [W:0.853 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site