Messages in this thread | | | Date | Thu, 14 Sep 2023 21:59:26 -0700 | From | Kees Cook <> | Subject | Re: [PATCH] drm/nouveau/pm: refactor deprecated strncpy |
| |
On Thu, Sep 14, 2023 at 10:17:08PM +0000, Justin Stitt wrote: > `strncpy` is deprecated for use on NUL-terminated destination strings [1]. > > We should prefer more robust and less ambiguous string interfaces. > > A suitable replacement is `strscpy` [2] due to the fact that it guarantees > NUL-termination on the destination buffer without unnecessarily NUL-padding. > > Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings [1] > Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html [2] > Link: https://github.com/KSPP/linux/issues/90 > Cc: linux-hardening@vger.kernel.org > Signed-off-by: Justin Stitt <justinstitt@google.com>
The "- 1" use in the original code is strong evidence for this being a sane conversion. :)
Reviewed-by: Kees Cook <keescook@chromium.org>
-- Kees Cook
| |