Messages in this thread | | | From | Yuan Tan <> | Subject | [PATCH v3 0/3] Kconfig: Add dependencies of POWER_RESET for x86 | Date | Thu, 14 Sep 2023 18:35:52 +0800 |
| |
These patches are to add dependencies of POWER_RESET for x86.
I sent v1 and v2 to the wrong x86 repository and email list. Here is v3.
As I have to use "savedefconfig" on the latest branch of different architectures, I am sending separate patches for each architecture in v3.
To simplify the enablement of the poweroff support, selecting the required options for CONFIG_POWER_RESET=y may make many people happy especially when they are using a customized config (maybe tinyconfig based) for a target qemu board. Without normal poweroff support from the kernel side, qemu will simply hang[1] there after a 'poweroff' command, which is a very bad experience for the automatical tests.
However, CONFIG_POWER_RESET is ineffective if there are no dependencies that enable certain devices in Kconfig.
Currently, based on tinyconfig, it is very hard to find the exact poweroff related option[2]. Some architectures' poweroff works well without any dependence, the others' poweroff options are hidden deeply, which make things hard.
After multiple verifications, these options have been identified as the minimum dependencies required for poweroff to function normally. Additionally, 'make savedefconfig' simplifies the defconfig automatically.
Zhangjin and I invested a significant amount of time in searching for the current options on these devices. We hope that this set of patches will save time for others. If community like it, we will consider adding dependencies for POWER_RESET on other devices.
We hope every device's CONFIG_POWER_RESET will have proper dependencies. :)
--- [1]: https://lore.kernel.org/lkml/511b2f6009fb830b3f32b4be3dca99596c684fa3.1689759351.git.falcon@tinylab.org/ [2]: https://lore.kernel.org/all/983843582e52e83fba79ad45cea6c79e1f62ec6c.1690489039.git.falcon@tinylab.org/
v1: https://lore.kernel.org/all/20230831201727.3177853-1-tanyuan@tinylab.org/ v2: https://lore.kernel.org/all/cover.1693535514.git.tanyuan@tinylab.org/
--- Changes in v2: - Fix the mistake of using spaces instead of tabs in kconfig.
Changes in v3: - Enable POWER_RESET and simplify the deconfig.
Yuan Tan (3): x86/config: Cleanup i386_defconfig and x86_64_defconfig Kconfig: Add dependencies of POWER_RESET for x86 x86/config: Simplify i386_defconfig and x86_64_defconfig
arch/x86/Kconfig | 2 ++ arch/x86/configs/i386_defconfig | 31 ++++++++++--------------------- arch/x86/configs/x86_64_defconfig | 9 ++------- 3 files changed, 14 insertions(+), 28 deletions(-)
base-commit: 84b81a67e9cba5466178e47c20c0628359a242b0 -- 2.34.1
| |