Messages in this thread | | | Date | Wed, 9 Aug 2023 15:19:27 +0200 | Subject | Re: [PATCH] tty: serial: samsung: Set missing PM ops for hibernation support | From | Anton Eliasson <> |
| |
On 07/08/2023 15.50, Krzysztof Kozlowski wrote: > On 03/08/2023 13:26, Anton Eliasson wrote: >> At least freeze, restore and thaw need to be set in order for the driver >> to support system hibernation. The existing suspend/resume functions can >> be reused since those functions don't touch the device's power state or >> wakeup capability. Use the helper macros SET_SYSTEM_SLEEP_PM_OPS and >> SET_NOIRQ_SYSTEM_SLEEP_PM_OPS for symmetry with similar drivers. >> > Looks sensible, although you should also test the other sleep methods, > e.g. suspend to idle. > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Best regards, > Krzysztof > Yes, s2idle still works. Standby / Power-On Suspend and s2ram we don't have support for so I can't test it. Thanks for the review!
Anton Eliasson
| |