Messages in this thread | | | Date | Mon, 7 Aug 2023 15:50:35 +0200 | Subject | Re: [PATCH] tty: serial: samsung: Set missing PM ops for hibernation support | From | Krzysztof Kozlowski <> |
| |
On 03/08/2023 13:26, Anton Eliasson wrote: > At least freeze, restore and thaw need to be set in order for the driver > to support system hibernation. The existing suspend/resume functions can > be reused since those functions don't touch the device's power state or > wakeup capability. Use the helper macros SET_SYSTEM_SLEEP_PM_OPS and > SET_NOIRQ_SYSTEM_SLEEP_PM_OPS for symmetry with similar drivers. >
Looks sensible, although you should also test the other sleep methods, e.g. suspend to idle.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards, Krzysztof
| |