Messages in this thread | | | Date | Wed, 9 Aug 2023 15:10:59 +0530 | From | Dhruva Gole <> | Subject | Re: [PATCH v2 1/3] bus: ti-sysc: Fix build warning for 64-bit build |
| |
On Aug 09, 2023 at 12:27:20 +0300, Tony Lindgren wrote: > Fix "warning: cast from pointer to integer of different size" on 64-bit > builds. > > Note that this is a cosmetic fix at this point as the driver is not yet > used for 64-bit systems. > > Fixes: feaa8baee82a ("bus: ti-sysc: Implement SoC revision handling") > Signed-off-by: Tony Lindgren <tony@atomide.com> > --- > drivers/bus/ti-sysc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c > --- a/drivers/bus/ti-sysc.c > +++ b/drivers/bus/ti-sysc.c > @@ -3104,7 +3104,7 @@ static int sysc_init_static_data(struct sysc *ddata) > > match = soc_device_match(sysc_soc_match); > if (match && match->data) > - sysc_soc->soc = (int)match->data; > + sysc_soc->soc = (enum sysc_soc)match->data;
Thanks for the suggestion Nishanth,
Reviewed-by: Dhruva Gole <d-gole@ti.com>
Maybe something unrelated to this patch, but the driver has some minor warning when built with W=1:
make W=1 ARCH=arm64 CROSS_COMPILE=aarch64-none-linux-gnu- drivers/bus/ti-sysc.o
drivers/bus/ti-sysc.c:156: warning: Function parameter or member 'sysconfig' not described in 'sysc'
> > /* > * Check and warn about possible old incomplete dtb. We now want to see > -- > 2.41.0
-- Best regards, Dhruva Gole <d-gole@ti.com>
| |