lkml.org 
[lkml]   [2023]   [Aug]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 6/7] selinux: avoid implicit conversions in policydb code
On Aug  7, 2023 =?UTF-8?q?Christian=20G=C3=B6ttsche?= <cgzones@googlemail.com> wrote:
>
> Use the identical type for local variables, e.g. loop counters.
>
> Declare members of struct policydb_compat_info unsigned to consistently
> use unsigned iterators. They hold read-only non-negative numbers in the
> global variable policydb_compat.
>
> Signed-off-by: Christian Göttsche <cgzones@googlemail.com>
> ---
> v3:
> - use unsigned int instead of u32 for iterators where the loop bound
> is known at compile time and small (<100)
> /@Paul: keep u32 iterator in policydb_destroy() due to
> / for (i = 0; i < p->p_types.nprim; i++)
> /
> - drop not mentioned protocol and port checks regarding out of range
> values; there are a couple more of them and those changes are
> suitable for a different patchset
> v2:
> - avoid declarations in init-clauses of for loops
> - declare members of struct policydb_compat_info unsigned
> ---
> security/selinux/ss/policydb.c | 69 ++++++++++++++++++----------------
> 1 file changed, 37 insertions(+), 32 deletions(-)

Merged into selinux/next, thanks.

--
paul-moore.com

\
 
 \ /
  Last update: 2023-08-10 01:08    [W:0.089 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site