Messages in this thread | | | Date | Wed, 09 Aug 2023 19:07:40 -0400 | From | Paul Moore <> | Subject | Re: [PATCH v3 1/7] selinux: avoid implicit conversions in avtab code |
| |
On Aug 7, 2023 =?UTF-8?q?Christian=20G=C3=B6ttsche?= <cgzones@googlemail.com> wrote: > > Return u32 from avtab_hash() instead of int, since the hashing is done > on u32 and the result is used as an index on the hash array. > > Use the type of the limit in for loops. > > Avoid signed to unsigned conversion of multiplication result in > avtab_hash_eval() and perform multiplication in destination type. > > Use unsigned loop iterator for index operations, to avoid sign > extension. > > Signed-off-by: Christian Göttsche <cgzones@googlemail.com> > --- > v3: > - use fixed sized counters in avtab_hash_eval() > - perform multiplication in avtab_hash_eval() in destination type > v2: avoid declarations in init-clauses of for loops > --- > security/selinux/ss/avtab.c | 24 ++++++++++++------------ > 1 file changed, 12 insertions(+), 12 deletions(-)
Merged into selinux/next, thanks.
-- paul-moore.com
| |