Messages in this thread | | | Date | Tue, 8 Aug 2023 10:36:24 +0200 | Subject | Re: [PATCH v3 3/9] i2c: xlp9xx: Use dev_err_probe in probe function | From | Krzysztof Kozlowski <> |
| |
On 08/08/2023 03:29, Liao Chang wrote: > Use the dev_err_probe function instead of dev_err in the probe function > so that the printed messge includes the return value and also handles > -EPROBE_DEFER nicely. > > Reviewed-by: Andi Shyti <andi.shyti@kernel.org> > Signed-off-by: Liao Chang <liaochang1@huawei.com> > --- > drivers/i2c/busses/i2c-xlp9xx.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-xlp9xx.c b/drivers/i2c/busses/i2c-xlp9xx.c > index f59e8c544f36..08a59a920929 100644 > --- a/drivers/i2c/busses/i2c-xlp9xx.c > +++ b/drivers/i2c/busses/i2c-xlp9xx.c > @@ -529,10 +529,8 @@ static int xlp9xx_i2c_probe(struct platform_device *pdev) > > err = devm_request_irq(&pdev->dev, priv->irq, xlp9xx_i2c_isr, 0, > pdev->name, priv); > - if (err) { > - dev_err(&pdev->dev, "IRQ request failed!\n");
I don't think this is needed: https://lore.kernel.org/all/20230721094641.77189-1-frank.li@vivo.com/
Best regards, Krzysztof
| |