lkml.org 
[lkml]   [2023]   [Aug]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v3 8/9] i2c: imx-lpi2c: Use dev_err_probe in probe function
    Date
    Use the dev_err_probe function instead of dev_err in the probe function
    so that the printed messge includes the return value and also handles
    -EPROBE_DEFER nicely.

    Reviewed-by: Andi Shyti <andi.shyti@kernel.org>
    Signed-off-by: Liao Chang <liaochang1@huawei.com>
    ---
    drivers/i2c/busses/i2c-imx-lpi2c.c | 12 ++++--------
    1 file changed, 4 insertions(+), 8 deletions(-)

    diff --git a/drivers/i2c/busses/i2c-imx-lpi2c.c b/drivers/i2c/busses/i2c-imx-lpi2c.c
    index c3287c887c6f..bfa788b3775b 100644
    --- a/drivers/i2c/busses/i2c-imx-lpi2c.c
    +++ b/drivers/i2c/busses/i2c-imx-lpi2c.c
    @@ -569,10 +569,8 @@ static int lpi2c_imx_probe(struct platform_device *pdev)
    sizeof(lpi2c_imx->adapter.name));

    ret = devm_clk_bulk_get_all(&pdev->dev, &lpi2c_imx->clks);
    - if (ret < 0) {
    - dev_err(&pdev->dev, "can't get I2C peripheral clock, ret=%d\n", ret);
    - return ret;
    - }
    + if (ret < 0)
    + return dev_err_probe(&pdev->dev, ret, "can't get I2C peripheral clock\n");
    lpi2c_imx->num_clks = ret;

    ret = of_property_read_u32(pdev->dev.of_node,
    @@ -582,10 +580,8 @@ static int lpi2c_imx_probe(struct platform_device *pdev)

    ret = devm_request_irq(&pdev->dev, irq, lpi2c_imx_isr, 0,
    pdev->name, lpi2c_imx);
    - if (ret) {
    - dev_err(&pdev->dev, "can't claim irq %d\n", irq);
    - return ret;
    - }
    + if (ret)
    + return dev_err_probe(&pdev->dev, ret, "can't claim irq %d\n", irq);

    i2c_set_adapdata(&lpi2c_imx->adapter, lpi2c_imx);
    platform_set_drvdata(pdev, lpi2c_imx);
    --
    2.25.1
    \
     
     \ /
      Last update: 2023-08-08 03:31    [W:3.483 / U:0.252 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site