Messages in this thread | | | Date | Mon, 7 Aug 2023 16:47:55 -0500 | From | Andrew Halaney <> | Subject | Re: [PATCH 7/9] arm64: dts: qcom: sa8775p-ride: add the second SGMII PHY |
| |
On Mon, Aug 07, 2023 at 09:35:05PM +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > Add a second SGMII PHY that will be used by EMAC1 on sa8775p-ride. > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > --- > arch/arm64/boot/dts/qcom/sa8775p-ride.dts | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sa8775p-ride.dts b/arch/arm64/boot/dts/qcom/sa8775p-ride.dts > index 55feaac7fa1b..5b48066f312a 100644 > --- a/arch/arm64/boot/dts/qcom/sa8775p-ride.dts > +++ b/arch/arm64/boot/dts/qcom/sa8775p-ride.dts > @@ -286,6 +286,14 @@ sgmii_phy0: phy@8 { > reset-gpios = <&pmm8654au_2_gpios 8 GPIO_ACTIVE_LOW>; > reset-deassert-us = <70000>; > }; > + > + sgmii_phy1: phy@a { > + compatible = "ethernet-phy-id0141.0dd4"; > + reg = <0xa>; > + device_type = "ethernet-phy"; > + reset-gpios = <&pmm8654au_2_gpios 9 GPIO_ACTIVE_LOW>; > + reset-deassert-us = <70000>; > + };
This is connected to the (another) Marvell 88EA1512. I mentioned in the earlier patch for sgmii_phy0 that you dropped the reset-assert-us.
Unless there was a reason for that, I suspect you want to add it here too.
Otherwise the description matches the bit of schematic I have access to.
Thanks, Andrew
| |