lkml.org 
[lkml]   [2023]   [Aug]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V3 1/4] arm_pmu: acpi: Refactor arm_spe_acpi_register_device()
On Thu, Aug 03, 2023 at 11:43:27AM +0530, Anshuman Khandual wrote:
>
>
> On 8/3/23 11:26, Anshuman Khandual wrote:
> > + /*
> > + * Sanity check all the GICC tables for the same interrupt
> > + * number. For now, only support homogeneous ACPI machines.
> > + */
> > + for_each_possible_cpu(cpu) {
> > + struct acpi_madt_generic_interrupt *gicc;
> > +
> > + gicc = acpi_cpu_get_madt_gicc(cpu);
> > + if (gicc->header.length < len)
> > + return gsi ? -ENXIO : 0;
> > +
> > + this_gsi = parse_gsi(gicc);
> > + if (!this_gsi)
> > + return gsi ? -ENXIO : 0;
>
> Hello Will,
>
> Moved parse_gsi() return code checking to its original place just to
> make it similar in semantics to existing 'gicc->header.length check'.
> If 'gsi' is valid i.e atleast a single cpu has been probed, return
> -ENXIO indicating mismatch, otherwise just return 0.

Wouldn't that still be the case without the check in this hunk? We'd run
into the homogeneous check and return -ENXIO from there, no?

Will

\
 
 \ /
  Last update: 2023-08-04 18:40    [W:0.047 / U:0.308 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site