Messages in this thread | | | Date | Thu, 3 Aug 2023 11:43:27 +0530 | Subject | Re: [PATCH V3 1/4] arm_pmu: acpi: Refactor arm_spe_acpi_register_device() | From | Anshuman Khandual <> |
| |
On 8/3/23 11:26, Anshuman Khandual wrote: > + /* > + * Sanity check all the GICC tables for the same interrupt > + * number. For now, only support homogeneous ACPI machines. > + */ > + for_each_possible_cpu(cpu) { > + struct acpi_madt_generic_interrupt *gicc; > + > + gicc = acpi_cpu_get_madt_gicc(cpu); > + if (gicc->header.length < len) > + return gsi ? -ENXIO : 0; > + > + this_gsi = parse_gsi(gicc); > + if (!this_gsi) > + return gsi ? -ENXIO : 0;
Hello Will,
Moved parse_gsi() return code checking to its original place just to make it similar in semantics to existing 'gicc->header.length check'. If 'gsi' is valid i.e atleast a single cpu has been probed, return -ENXIO indicating mismatch, otherwise just return 0.
- Anshuman
| |