Messages in this thread Patch in this message | | | From | Zhu Wang <> | Subject | [PATCH -next v4] drm/i2c: tda998x: remove redundant CONFIG_OF and of_match_ptr() | Date | Fri, 4 Aug 2023 19:06:25 +0800 |
| |
The driver depends on CONFIG_OF, so it is not necessary to use CONFIG_OF and of_match_ptr() here, we remove them all.
Even for drivers that do not depend on CONFIG_OF, it's almost always better to leave out the of_match_ptr(), since the only thing it can possibly do is to save a few bytes of .text if a driver can be used both with and without it.
Signed-off-by: Zhu Wang <wangzhu9@huawei.com> Reviewed-by: Arnd Bergmann <arnd@arndb.de>
--- Changes in v2: - Remove CONFIG_OF which includes tda998x_ids.
--- Changes in v3: - Changes of_match_ptr to of_match_ptr() in the commit message.
--- Changes in v4: - Remove "Reviewed-by: Andy Shevchenko". --- drivers/gpu/drm/i2c/tda998x_drv.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c b/drivers/gpu/drm/i2c/tda998x_drv.c index d8d7de18dd65..9666e0746240 100644 --- a/drivers/gpu/drm/i2c/tda998x_drv.c +++ b/drivers/gpu/drm/i2c/tda998x_drv.c @@ -2084,13 +2084,11 @@ static void tda998x_remove(struct i2c_client *client) tda998x_destroy(&client->dev); } -#ifdef CONFIG_OF static const struct of_device_id tda998x_dt_ids[] = { { .compatible = "nxp,tda998x", }, { } }; MODULE_DEVICE_TABLE(of, tda998x_dt_ids); -#endif static const struct i2c_device_id tda998x_ids[] = { { "tda998x", 0 }, @@ -2103,7 +2101,7 @@ static struct i2c_driver tda998x_driver = { .remove = tda998x_remove, .driver = { .name = "tda998x", - .of_match_table = of_match_ptr(tda998x_dt_ids), + .of_match_table = tda998x_dt_ids, }, .id_table = tda998x_ids, }; -- 2.17.1
| |