lkml.org 
[lkml]   [2023]   [Aug]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH RFC v2 01/18] cxl/hdm: Debug, use decoder name function
From


On 8/28/23 22:20, Ira Weiny wrote:
> The decoder enum has a name conversion function defined now.
>
> Use that instead of open coding.
>
> Suggested-by: Navneet Singh <navneet.singh@intel.com>
> Signed-off-by: Ira Weiny <ira.weiny@intel.com>

As others said, send this upstream outside of the series.

Reviewed-by: Dave Jiang <dave.jiang@intel.com>
>
> ---
> Changes for v2:
> [iweiny: new patch, split out]
> ---
> drivers/cxl/core/hdm.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/cxl/core/hdm.c b/drivers/cxl/core/hdm.c
> index b01a77b67511..a254f79dd4e8 100644
> --- a/drivers/cxl/core/hdm.c
> +++ b/drivers/cxl/core/hdm.c
> @@ -550,8 +550,7 @@ int cxl_dpa_alloc(struct cxl_endpoint_decoder *cxled, unsigned long long size)
>
> if (size > avail) {
> dev_dbg(dev, "%pa exceeds available %s capacity: %pa\n", &size,
> - cxled->mode == CXL_DECODER_RAM ? "ram" : "pmem",
> - &avail);
> + cxl_decoder_mode_name(cxled->mode), &avail);
> rc = -ENOSPC;
> goto out;
> }
>

\
 
 \ /
  Last update: 2023-08-30 22:34    [W:0.886 / U:22.608 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site