lkml.org 
[lkml]   [2023]   [Aug]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] mmc: Fix force card detect in sdhci
Date
From: Mathieu Moneyron <mathieu.moneyron@gmail.com>

On the ATMEL at91 when using the non-removable flag in device tree and not
using the card-detect pin inside the device-tree pinctrl, the card detect
pin is physically still used which can cause unknown behaviour when this
pin is used for other purposes.

From my interpretation this seems to be caused by a hardware design flaw
and the real hardware is not working as intended by the documentation.

Signed-off-by: Mathieu Moneyron <mathieu.moneyron@gmail.com>
---
drivers/mmc/host/sdhci-of-at91.c | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/drivers/mmc/host/sdhci-of-at91.c b/drivers/mmc/host/sdhci-of-at91.c
index 69fef88e7..4fd6bfbf6 100644
--- a/drivers/mmc/host/sdhci-of-at91.c
+++ b/drivers/mmc/host/sdhci-of-at91.c
@@ -51,10 +51,15 @@ struct sdhci_at91_priv {
static void sdhci_at91_set_force_card_detect(struct sdhci_host *host)
{
u8 mc1r;
+ u8 ctrl;

mc1r = readb(host->ioaddr + SDMMC_MC1R);
mc1r |= SDMMC_MC1R_FCD;
writeb(mc1r, host->ioaddr + SDMMC_MC1R);
+
+ ctrl = readb(host->ioaddr + SDHCI_HOST_CONTROL);
+ ctrl |= SDHCI_CTRL_CDTEST_INS | SDHCI_CTRL_CDTEST_EN;
+ writeb(ctrl, host->ioaddr + SDHCI_HOST_CONTROL);
}

static void sdhci_at91_set_clock(struct sdhci_host *host, unsigned int clock)
--
2.25.1
\
 
 \ /
  Last update: 2023-08-30 21:17    [W:0.064 / U:0.580 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site