lkml.org 
[lkml]   [2023]   [Aug]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[tip: x86/shstk] x86/shstk: Change order of __user in type
The following commit has been merged into the x86/shstk branch of tip:

Commit-ID: 1fe428d3692fb10a0e8d85fafe719b154e43ad4e
Gitweb: https://git.kernel.org/tip/1fe428d3692fb10a0e8d85fafe719b154e43ad4e
Author: Rick Edgecombe <rick.p.edgecombe@intel.com>
AuthorDate: Thu, 24 Aug 2023 18:45:54 -07:00
Committer: Dave Hansen <dave.hansen@linux.intel.com>
CommitterDate: Wed, 30 Aug 2023 10:35:53 -07:00

x86/shstk: Change order of __user in type

0day reports a sparse warning:
arch/x86/kernel/shstk.c:295:55: sparse: sparse: cast removes address space
'__user' of expression

The __user is in the wrong spot. Move it to right spot and make sparse
happy.

Closes: https://lore.kernel.org/oe-kbuild-all/202308222312.Jt4Tog5T-lkp@intel.com/
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Rick Edgecombe <rick.p.edgecombe@intel.com>
Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
Link: https://lore.kernel.org/all/20230825014554.1769194-1-rick.p.edgecombe%40intel.com
---
arch/x86/kernel/shstk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/shstk.c b/arch/x86/kernel/shstk.c
index cd10d07..fd68992 100644
--- a/arch/x86/kernel/shstk.c
+++ b/arch/x86/kernel/shstk.c
@@ -275,7 +275,7 @@ static int shstk_push_sigframe(unsigned long *ssp)
return -EINVAL;

*ssp -= SS_FRAME_SIZE;
- if (put_shstk_data((void *__user)*ssp, target_ssp))
+ if (put_shstk_data((void __user *)*ssp, target_ssp))
return -EFAULT;

return 0;
\
 
 \ /
  Last update: 2023-08-30 21:07    [W:0.233 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site