Messages in this thread | | | From | Miguel Ojeda <> | Date | Thu, 3 Aug 2023 16:20:36 +0200 | Subject | Re: [PATCH v2] rust: macros: vtable: fix `HAS_*` redefinition (`gen_const_name`) |
| |
On Thu, Aug 3, 2023 at 4:10 PM Qingsong Chen <changxian.cqs@antgroup.com> wrote: > > ```rust > #[vtable] > pub trait Foo { > #[cfg(CONFIG_X)] > fn bar(); > > #[cfg(not(CONFIG_X))] > fn bar(x: usize); > } > ```
I forgot to mention this in v1: the code does not need to be indented, since it is in a ``` block. Or you could remove the block, and keep the indentation. Both ways are fine.
> Changelog: > ---------- > v1 -> v2: > - Use `BTreeSet` and existing `consts` as suggested by Alice and Gary. > - Reword commit messages as suggested by Miguel. > ====================
The changelog for a patch should be placed after the `---` line below the Signed-off-by. That means it will not be part of the commit message that will land in Git. See e.g. how Martin did it here: https://lore.kernel.org/rust-for-linux/20230520231701.46008-1-yakoyoku@gmail.com/
No need to send a v3 for these two nits: I can fix it on my side when I apply it if others are happy with this version of the patch.
Thanks!
Cheers, Miguel
| |