Messages in this thread | | | Date | Thu, 3 Aug 2023 21:47:57 +0200 | Subject | Re: [PATCH v2] rust: macros: vtable: fix `HAS_*` redefinition (`gen_const_name`) | From | Alice Ryhl <> |
| |
On 8/3/23 16:09, Qingsong Chen wrote: > If we define the same function name twice in a trait (using `#[cfg]`), > the `vtable` macro will redefine its `gen_const_name`, e.g. this will > define `HAS_BAR` twice: > > ```rust > #[vtable] > pub trait Foo { > #[cfg(CONFIG_X)] > fn bar(); > > #[cfg(not(CONFIG_X))] > fn bar(x: usize); > } > ``` > > Changelog: > ---------- > v1 -> v2: > - Use `BTreeSet` and existing `consts` as suggested by Alice and Gary. > - Reword commit messages as suggested by Miguel. > ==================== > > Fixes: b44becc5ee80 ("rust: macros: add `#[vtable]` proc macro") > Signed-off-by: Qingsong Chen <changxian.cqs@antgroup.com>
Reviewed-by: Alice Ryhl <aliceryhl@google.com>
| |