lkml.org 
[lkml]   [2023]   [Aug]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] kconfig: avoid an infinite loop in oldconfig/syncconfig
Date
Exit on error when asking for value that has an invalid default value
and stdin is closed. Previously, this case would loop.

Signed-off-by: Yoann Congal <yoann.congal@smile.fr>
---
scripts/kconfig/conf.c | 9 +++++++++
1 file changed, 9 insertions(+)

diff --git a/scripts/kconfig/conf.c b/scripts/kconfig/conf.c
index 33d19e419908b..38ff9c81e071d 100644
--- a/scripts/kconfig/conf.c
+++ b/scripts/kconfig/conf.c
@@ -376,6 +376,15 @@ static int conf_string(struct menu *menu)
}
if (def && sym_set_string_value(sym, def))
return 0;
+ else {
+ if (feof(stdin) && !sym_string_valid(sym, sym_get_string_value(sym))) {
+ fprintf(stderr,
+ "Symbol %s has invalid default value and stdin reached EOF\n",
+ sym->name);
+ exit(1);
+ }
+ }
+
}
}

--
2.30.2
\
 
 \ /
  Last update: 2023-08-03 18:42    [W:0.022 / U:0.400 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site