Messages in this thread | | | Date | Thu, 24 Aug 2023 16:32:37 +0800 | Subject | Re: [PATCH V2 1/6] soc: amlogic: modify some power domains property | From | Xianwei Zhao <> |
| |
Hi Neil, Thanks for your replay.
On 2023/8/24 16:24, Neil Armstrong wrote: > [ EXTERNAL EMAIL ] > > Hi, > > On 24/08/2023 07:59, Xianwei Zhao wrote: >> From: "xianwei.zhao" <xianwei.zhao@amlogic.com> >> >> Some power domains for C3 can be using runtime PM, >> remove ALWAYS_ON property. And add some power domains >> description when ALWAYS_ON property. > > The subject should now be: > genpd: amlogic: .... > > same for patches 2 & 5. Will do. > >> >> Signed-off-by: xianwei.zhao <xianwei.zhao@amlogic.com> >> --- >> V1 -> V2: None >> --- >> drivers/genpd/amlogic/meson-secure-pwrc.c | 25 ++++++++++++----------- >> 1 file changed, 13 insertions(+), 12 deletions(-) >> >> diff --git a/drivers/genpd/amlogic/meson-secure-pwrc.c >> b/drivers/genpd/amlogic/meson-secure-pwrc.c >> index 89c881c56cd7..5ac2437ab8ad 100644 >> --- a/drivers/genpd/amlogic/meson-secure-pwrc.c >> +++ b/drivers/genpd/amlogic/meson-secure-pwrc.c >> @@ -122,18 +122,19 @@ static struct meson_secure_pwrc_domain_desc >> a1_pwrc_domains[] = { >> }; >> >> static struct meson_secure_pwrc_domain_desc c3_pwrc_domains[] = { >> - SEC_PD(C3_NNA, 0), >> - SEC_PD(C3_AUDIO, GENPD_FLAG_ALWAYS_ON), >> - SEC_PD(C3_SDIOA, GENPD_FLAG_ALWAYS_ON), >> - SEC_PD(C3_EMMC, GENPD_FLAG_ALWAYS_ON), >> - SEC_PD(C3_USB_COMB, GENPD_FLAG_ALWAYS_ON), >> - SEC_PD(C3_SDCARD, GENPD_FLAG_ALWAYS_ON), >> - SEC_PD(C3_ETH, GENPD_FLAG_ALWAYS_ON), >> - SEC_PD(C3_GE2D, GENPD_FLAG_ALWAYS_ON), >> - SEC_PD(C3_CVE, GENPD_FLAG_ALWAYS_ON), >> - SEC_PD(C3_GDC_WRAP, GENPD_FLAG_ALWAYS_ON), >> - SEC_PD(C3_ISP_TOP, GENPD_FLAG_ALWAYS_ON), >> - SEC_PD(C3_MIPI_ISP_WRAP, GENPD_FLAG_ALWAYS_ON), >> + SEC_PD(C3_NNA, 0), >> + SEC_PD(C3_AUDIO, 0), >> + SEC_PD(C3_SDIOA, 0), >> + SEC_PD(C3_EMMC, 0), >> + SEC_PD(C3_USB_COMB, 0), >> + SEC_PD(C3_SDCARD, 0), >> + /* ETH is for ethernet online wakeup, and should be always on */ >> + SEC_PD(C3_ETH, GENPD_FLAG_ALWAYS_ON), >> + SEC_PD(C3_GE2D, 0), >> + SEC_PD(C3_CVE, 0), >> + SEC_PD(C3_GDC_WRAP, 0), >> + SEC_PD(C3_ISP_TOP, 0), >> + SEC_PD(C3_MIPI_ISP_WRAP, 0), >> SEC_PD(C3_VCODEC, 0), >> }; >> >> >> base-commit: 413f5c02929bb33042bbc4ee233166550a5fca70 > > With changed subject: > Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
| |