Messages in this thread | | | Date | Tue, 22 Aug 2023 13:09:22 +0300 | Subject | Re: [PATCH v3 4/9] selftests/sgx: Fix linker script asserts | From | "Jarkko Sakkinen" <> |
| |
On Sat Aug 19, 2023 at 12:43 PM EEST, Jo Van Bulck wrote: > DEFINED only considers symbols, not section names. Hence, replace the > check for .got.plt with the _GLOBAL_OFFSET_TABLE_ symbol and remove other > (non-essential) asserts. > > Signed-off-by: Jo Van Bulck <jo.vanbulck@cs.kuleuven.be> > --- > tools/testing/selftests/sgx/test_encl.lds | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/tools/testing/selftests/sgx/test_encl.lds b/tools/testing/selftests/sgx/test_encl.lds > index b86c86060..13144b045 100644 > --- a/tools/testing/selftests/sgx/test_encl.lds > +++ b/tools/testing/selftests/sgx/test_encl.lds > @@ -37,8 +37,4 @@ SECTIONS > } > } > > -ASSERT(!DEFINED(.altinstructions), "ALTERNATIVES are not supported in enclaves") > -ASSERT(!DEFINED(.altinstr_replacement), "ALTERNATIVES are not supported in enclaves") > -ASSERT(!DEFINED(.discard.retpoline_safe), "RETPOLINE ALTERNATIVES are not supported in enclaves") > -ASSERT(!DEFINED(.discard.nospec), "RETPOLINE ALTERNATIVES are not supported in enclaves") > -ASSERT(!DEFINED(.got.plt), "Libcalls are not supported in enclaves") > +ASSERT(!DEFINED(_GLOBAL_OFFSET_TABLE_), "Libcalls through GOT are not supported in enclaves") > -- > 2.25.1
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
BR, Jarkko
| |