Messages in this thread Patch in this message | | | From | "Peng Fan (OSS)" <> | Subject | [PATCH V3 1/2] amba: bus: fix refcount leak | Date | Mon, 21 Aug 2023 10:39:27 +0800 |
| |
From: Peng Fan <peng.fan@nxp.com>
commit 5de1540b7bc4 ("drivers/amba: create devices from device tree") increases the refcount of of_node, but not releases it in amba_device_release, so there is refcount leak. By using of_node_put to avoid refcount leak.
Fixes: 5de1540b7bc4 ("drivers/amba: create devices from device tree") Signed-off-by: Peng Fan <peng.fan@nxp.com> ---
Note: Code inspection, not tested.
V3: Move this out from patch V2 1/1
drivers/amba/bus.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/amba/bus.c b/drivers/amba/bus.c index ce88af9eb562..09e72967b8ab 100644 --- a/drivers/amba/bus.c +++ b/drivers/amba/bus.c @@ -528,6 +528,7 @@ static void amba_device_release(struct device *dev) { struct amba_device *d = to_amba_device(dev); + of_node_put(d->dev.of_node); if (d->res.parent) release_resource(&d->res); mutex_destroy(&d->periphid_lock); -- 2.37.1
| |