lkml.org 
[lkml]   [2023]   [Aug]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v4] PCI/VGA: Make the vga_is_firmware_default() less arch-dependent
From
Hi,

On 2023/8/18 06:08, Bjorn Helgaas wrote:
>> +
>> +/*
>> + * Identify the PCI VGA device that contains the firmware framebuffer
>> + */
>> +static void pci_boot_vga_finder(struct pci_dev *pdev)
>> +{
>> + resource_size_t fb_start;
>> + resource_size_t fb_end;
>> + unsigned int i;
>> +
>> + /* Already found the pdev which has firmware framebuffer ownership */
>> + if (pdev_boot_vga)
>> + return;
>> +
>> + if (!vga_arb_get_firmware_fb_range(&fb_start, &fb_end))
>> + return;
>> +
>> + for (i = 0; i < PCI_STD_NUM_BARS; i++) {
>> + struct resource *res = &pdev->resource[i];
> This is essentially identical to vga_is_firmware_default() so it
> should look the same, i.e., it should use pci_dev_for_each_resource().
>

OK, will be fixed at the next version. Thanks.

\
 
 \ /
  Last update: 2023-08-19 04:19    [W:0.152 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site