lkml.org 
[lkml]   [2023]   [Aug]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v4] PCI/VGA: Make the vga_is_firmware_default() less arch-dependent
From
Hi,


On 2023/8/18 06:08, Bjorn Helgaas wrote:
>> + if (resource_type(res) != IORESOURCE_MEM)
>> + continue;
>> +
>> + if (!res->start || !res->end)
>> + continue;
>> +
>> + if (res->start <= fb_start && fb_end <= res->end) {
>> + pdev_boot_vga = pdev;
>> +
>> + vgaarb_info(&pdev->dev,
>> + "BAR %d contains firmware FB\n", i);
> Print the BAR with %pR and include the framebuffer region from
> screen_info in the same format.
>

I do remember that you already told me to do this in V3, sorry for not
replying to you at V3. Most of the time, what you tell me is right.But
here, I think I need to explain. Because doing it that way will make the
code line too long,and it will exceed 80 characters in the column if we
print too much.
I believe that the vgaarb_info() at here is already the most compact and
simplest form. Printing the BAR with %pR is not absolute necessary,
because we can get the additional information by: $ lspci | grep VGA

$ dmesg | grep 05:00.0
$ dmesg | grep 0000:03:00.0
$ dmesg | grep PCI


Actually, I only add something that is absolute necessary.
Printing BAR with %pR and/or Printing the framebuffer region
is consider to only for *debugging* purpose.

\
 
 \ /
  Last update: 2023-08-18 03:50    [W:0.120 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site