Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Thu, 17 Aug 2023 09:31:07 +0200 | Subject | Re: [PATCH] phy: realtek: Realtek PHYs should depend on ARCH_REALTEK |
| |
Hi Vinod,
On Thu, Aug 17, 2023 at 8:46 AM Vinod Koul <vkoul@kernel.org> wrote: > On 17-08-23, 02:06, Stanley Chang[昌育德] wrote: > > > diff --git a/drivers/phy/realtek/Kconfig b/drivers/phy/realtek/Kconfig index > > > 650e20ed69af41d2..75ac7e7c31aec6f2 100644 > > > --- a/drivers/phy/realtek/Kconfig > > > +++ b/drivers/phy/realtek/Kconfig > > > @@ -2,6 +2,9 @@ > > > # > > > # Phy drivers for Realtek platforms > > > # > > > + > > > +if ARCH_REALTEK || COMPILE_TEST > > > + > > > config PHY_RTK_RTD_USB2PHY > > > tristate "Realtek RTD USB2 PHY Transceiver Driver" > > > depends on USB_SUPPORT > > > @@ -25,3 +28,5 @@ config PHY_RTK_RTD_USB3PHY > > > The DHC (digital home center) RTD series SoCs used the Synopsys > > > DWC3 USB IP. This driver will do the PHY initialization > > > of the parameters. > > > + > > > +endif # ARCH_REALTEK || COMPILE_TEST > > > > Thanks for your patch. > > Why not use "depends on"? > > depends on ARCH_MEDIATEK || COMPILE_TEST > > I think this patch is better, this way all future rtek drivers will be > fixed as well, no need to add for each driver
Indeed.
The only caveat is future non-on-SoC Realtek PHY drivers: they should be added outside the if/endif block.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |