Messages in this thread | | | Date | Thu, 17 Aug 2023 12:16:27 +0530 | From | Vinod Koul <> | Subject | Re: [PATCH] phy: realtek: Realtek PHYs should depend on ARCH_REALTEK |
| |
On 17-08-23, 02:06, Stanley Chang[昌育德] wrote: > Hi Geert, > > > diff --git a/drivers/phy/realtek/Kconfig b/drivers/phy/realtek/Kconfig index > > 650e20ed69af41d2..75ac7e7c31aec6f2 100644 > > --- a/drivers/phy/realtek/Kconfig > > +++ b/drivers/phy/realtek/Kconfig > > @@ -2,6 +2,9 @@ > > # > > # Phy drivers for Realtek platforms > > # > > + > > +if ARCH_REALTEK || COMPILE_TEST > > + > > config PHY_RTK_RTD_USB2PHY > > tristate "Realtek RTD USB2 PHY Transceiver Driver" > > depends on USB_SUPPORT > > @@ -25,3 +28,5 @@ config PHY_RTK_RTD_USB3PHY > > The DHC (digital home center) RTD series SoCs used the Synopsys > > DWC3 USB IP. This driver will do the PHY initialization > > of the parameters. > > + > > +endif # ARCH_REALTEK || COMPILE_TEST > > Thanks for your patch. > Why not use "depends on"? > depends on ARCH_MEDIATEK || COMPILE_TEST
I think this patch is better, this way all future rtek drivers will be fixed as well, no need to add for each driver
-- ~Vinod
| |