lkml.org 
[lkml]   [2023]   [Aug]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH v1 1/1] kstrtox: Consistently use _tolower()
Date
We already use _tolower() in other places, so convert the one
which open codes it.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---

Note, there is a desire to use hex_to_bin() instead all that stuff.
BUT. On x96_64 it gets +15 bytes to the code, which seems due to
exported function in use. Dunno if it makes sense to have hex_to_bin()
actually be static inline (since it doesn't use ctype.h anymore).
Anyway, this may be a material for another patch.

lib/kstrtox.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/kstrtox.c b/lib/kstrtox.c
index 08c14019841a..d586e6af5e5a 100644
--- a/lib/kstrtox.c
+++ b/lib/kstrtox.c
@@ -59,7 +59,7 @@ unsigned int _parse_integer_limit(const char *s, unsigned int base, unsigned lon
rv = 0;
while (max_chars--) {
unsigned int c = *s;
- unsigned int lc = c | 0x20; /* don't tolower() this line */
+ unsigned int lc = _tolower(c);
unsigned int val;

if ('0' <= c && c <= '9')
--
2.40.0.1.gaa8946217a0b
\
 
 \ /
  Last update: 2023-08-17 17:01    [W:0.019 / U:0.836 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site