Messages in this thread | | | Date | Thu, 17 Aug 2023 10:53:41 +0100 | Subject | Re: [PATCH v6 4/6] perf jevents: Add a new expression builtin strcmp_cpuid_str() | From | John Garry <> |
| |
On 16/08/2023 12:47, James Clark wrote: > This will allow writing formulas that are conditional on a specific > CPU type or CPU version. It calls through to the existing > strcmp_cpuid_str() function in Perf which has a default weak version, > and an arch specific version for x86 and arm64. > > The function takes an 'ID' type value, which is a string. But in this > case Arm CPU IDs are hex numbers prefixed with '0x'. metric.py > assumes strings are only used by event names, and that they can't start > with a number ('0'), so an additional change has to be made to the > regex to convert hex numbers back to 'ID' types. > > Signed-off-by: James Clark<james.clark@arm.com>
Reviewed-by: John Garry <john.g.garry@oracle.com>
| |