Messages in this thread | | | Date | Thu, 17 Aug 2023 17:45:53 +0800 | From | kernel test robot <> | Subject | drivers/block/drbd/drbd_bitmap.c:1222: warning: Function parameter or member 'peer_device' not described in 'drbd_bm_read' |
| |
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 4853c74bd7ab7fdb83f319bd9ace8a08c031e9b6 commit: 8164dd6c8ae158ec0740bf37f0f14645a1fb5355 drbd: Add peer device parameter to whole-bitmap I/O handlers date: 5 months ago config: sparc-allyesconfig (https://download.01.org/0day-ci/archive/20230817/202308171726.ntrgXj1p-lkp@intel.com/config) compiler: sparc64-linux-gcc (GCC) 12.3.0 reproduce: (https://download.01.org/0day-ci/archive/20230817/202308171726.ntrgXj1p-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202308171726.ntrgXj1p-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/block/drbd/drbd_bitmap.c:1222: warning: Function parameter or member 'peer_device' not described in 'drbd_bm_read' >> drivers/block/drbd/drbd_bitmap.c:1234: warning: Function parameter or member 'peer_device' not described in 'drbd_bm_write' >> drivers/block/drbd/drbd_bitmap.c:1246: warning: Function parameter or member 'peer_device' not described in 'drbd_bm_write_all' >> drivers/block/drbd/drbd_bitmap.c:1273: warning: Function parameter or member 'peer_device' not described in 'drbd_bm_write_copy_pages' -- >> drivers/block/drbd/drbd_main.c:3415: warning: Function parameter or member 'peer_device' not described in 'drbd_bmio_set_n_write' >> drivers/block/drbd/drbd_main.c:3441: warning: Function parameter or member 'peer_device' not described in 'drbd_bmio_clear_n_write' >> drivers/block/drbd/drbd_main.c:3502: warning: Function parameter or member 'peer_device' not described in 'drbd_queue_bitmap_io' >> drivers/block/drbd/drbd_main.c:3544: warning: Function parameter or member 'peer_device' not described in 'drbd_bitmap_io'
vim +1222 drivers/block/drbd/drbd_bitmap.c
b411b3637fa71fc Philipp Reisner 2009-09-25 1214 b411b3637fa71fc Philipp Reisner 2009-09-25 1215 /** b411b3637fa71fc Philipp Reisner 2009-09-25 1216 * drbd_bm_read() - Read the whole bitmap from its on disk location. b30ab7913b0a7b1 Andreas Gruenbacher 2011-07-03 1217 * @device: DRBD device. b411b3637fa71fc Philipp Reisner 2009-09-25 1218 */ 8164dd6c8ae158e Andreas Gruenbacher 2023-03-30 1219 int drbd_bm_read(struct drbd_device *device, 8164dd6c8ae158e Andreas Gruenbacher 2023-03-30 1220 struct drbd_peer_device *peer_device) __must_hold(local) 8164dd6c8ae158e Andreas Gruenbacher 2023-03-30 1221 b411b3637fa71fc Philipp Reisner 2009-09-25 @1222 { 4ce4926683b820c Lars Ellenberg 2014-05-06 1223 return bm_rw(device, BM_AIO_READ, 0); b411b3637fa71fc Philipp Reisner 2009-09-25 1224 } b411b3637fa71fc Philipp Reisner 2009-09-25 1225 b411b3637fa71fc Philipp Reisner 2009-09-25 1226 /** b411b3637fa71fc Philipp Reisner 2009-09-25 1227 * drbd_bm_write() - Write the whole bitmap to its on disk location. b30ab7913b0a7b1 Andreas Gruenbacher 2011-07-03 1228 * @device: DRBD device. 19f843aa08e2d8f Lars Ellenberg 2010-12-15 1229 * 19f843aa08e2d8f Lars Ellenberg 2010-12-15 1230 * Will only write pages that have changed since last IO. b411b3637fa71fc Philipp Reisner 2009-09-25 1231 */ 8164dd6c8ae158e Andreas Gruenbacher 2023-03-30 1232 int drbd_bm_write(struct drbd_device *device, 8164dd6c8ae158e Andreas Gruenbacher 2023-03-30 1233 struct drbd_peer_device *peer_device) __must_hold(local) b411b3637fa71fc Philipp Reisner 2009-09-25 @1234 { 4ce4926683b820c Lars Ellenberg 2014-05-06 1235 return bm_rw(device, 0, 0); b411b3637fa71fc Philipp Reisner 2009-09-25 1236 } b411b3637fa71fc Philipp Reisner 2009-09-25 1237 d1aa4d04da8de5c Philipp Reisner 2012-08-08 1238 /** d1aa4d04da8de5c Philipp Reisner 2012-08-08 1239 * drbd_bm_write_all() - Write the whole bitmap to its on disk location. b30ab7913b0a7b1 Andreas Gruenbacher 2011-07-03 1240 * @device: DRBD device. d1aa4d04da8de5c Philipp Reisner 2012-08-08 1241 * d1aa4d04da8de5c Philipp Reisner 2012-08-08 1242 * Will write all pages. d1aa4d04da8de5c Philipp Reisner 2012-08-08 1243 */ 8164dd6c8ae158e Andreas Gruenbacher 2023-03-30 1244 int drbd_bm_write_all(struct drbd_device *device, 8164dd6c8ae158e Andreas Gruenbacher 2023-03-30 1245 struct drbd_peer_device *peer_device) __must_hold(local) d1aa4d04da8de5c Philipp Reisner 2012-08-08 @1246 { 4ce4926683b820c Lars Ellenberg 2014-05-06 1247 return bm_rw(device, BM_AIO_WRITE_ALL_PAGES, 0); d1aa4d04da8de5c Philipp Reisner 2012-08-08 1248 } d1aa4d04da8de5c Philipp Reisner 2012-08-08 1249 c7a58db4e9dc523 Lars Ellenberg 2013-12-20 1250 /** c7a58db4e9dc523 Lars Ellenberg 2013-12-20 1251 * drbd_bm_write_lazy() - Write bitmap pages 0 to @upper_idx-1, if they have changed. c7a58db4e9dc523 Lars Ellenberg 2013-12-20 1252 * @device: DRBD device. c7a58db4e9dc523 Lars Ellenberg 2013-12-20 1253 * @upper_idx: 0: write all changed pages; +ve: page index to stop scanning for changed pages c7a58db4e9dc523 Lars Ellenberg 2013-12-20 1254 */ c7a58db4e9dc523 Lars Ellenberg 2013-12-20 1255 int drbd_bm_write_lazy(struct drbd_device *device, unsigned upper_idx) __must_hold(local) c7a58db4e9dc523 Lars Ellenberg 2013-12-20 1256 { c7a58db4e9dc523 Lars Ellenberg 2013-12-20 1257 return bm_rw(device, BM_AIO_COPY_PAGES, upper_idx); c7a58db4e9dc523 Lars Ellenberg 2013-12-20 1258 } c7a58db4e9dc523 Lars Ellenberg 2013-12-20 1259 0e8488ade26b4b1 Lars Ellenberg 2012-04-25 1260 /** 0e8488ade26b4b1 Lars Ellenberg 2012-04-25 1261 * drbd_bm_write_copy_pages() - Write the whole bitmap to its on disk location. b30ab7913b0a7b1 Andreas Gruenbacher 2011-07-03 1262 * @device: DRBD device. 0e8488ade26b4b1 Lars Ellenberg 2012-04-25 1263 * 0e8488ade26b4b1 Lars Ellenberg 2012-04-25 1264 * Will only write pages that have changed since last IO. 0e8488ade26b4b1 Lars Ellenberg 2012-04-25 1265 * In contrast to drbd_bm_write(), this will copy the bitmap pages 0e8488ade26b4b1 Lars Ellenberg 2012-04-25 1266 * to temporary writeout pages. It is intended to trigger a full write-out 0e8488ade26b4b1 Lars Ellenberg 2012-04-25 1267 * while still allowing the bitmap to change, for example if a resync or online 0e8488ade26b4b1 Lars Ellenberg 2012-04-25 1268 * verify is aborted due to a failed peer disk, while local IO continues, or 0e8488ade26b4b1 Lars Ellenberg 2012-04-25 1269 * pending resync acks are still being processed. 0e8488ade26b4b1 Lars Ellenberg 2012-04-25 1270 */ 8164dd6c8ae158e Andreas Gruenbacher 2023-03-30 1271 int drbd_bm_write_copy_pages(struct drbd_device *device, 8164dd6c8ae158e Andreas Gruenbacher 2023-03-30 1272 struct drbd_peer_device *peer_device) __must_hold(local) 0e8488ade26b4b1 Lars Ellenberg 2012-04-25 @1273 { 4ce4926683b820c Lars Ellenberg 2014-05-06 1274 return bm_rw(device, BM_AIO_COPY_PAGES, 0); 19f843aa08e2d8f Lars Ellenberg 2010-12-15 1275 } 19f843aa08e2d8f Lars Ellenberg 2010-12-15 1276
:::::: The code at line 1222 was first introduced by commit :::::: b411b3637fa71fce9cf2acf0639009500f5892fe The DRBD driver
:::::: TO: Philipp Reisner <philipp.reisner@linbit.com> :::::: CC: Jens Axboe <jens.axboe@oracle.com>
-- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
| |