Messages in this thread | | | Subject | Re: [PATCH v3 2/2] hexdump: add a new dump prefix DUMP_PREFIX_CUSTOM | From | "Leizhen (ThunderTown)" <> | Date | Wed, 16 Aug 2023 14:32:28 +0800 |
| |
On 2023/8/16 11:34, Sergey Senozhatsky wrote: > On (23/08/16 11:20), Leizhen (ThunderTown) wrote: >>> IMHO, this is pretty bad interface. >>> >>> + From the user POV: >>> >>> It is far from clear what values will be passed for the given >>> printf format. It can be docummented but... >>> >>> >>> + From the security POV: >>> >>> The compiler could not check if the printk() parameters >>> match the format. I mean if the number of types of >>> the parameters are correct. >> >> Yes, it has these problems. So, back to v2, how about add DUMP_PREFIX_ADDRESS_LOW16? >> Or named DUMP_PREFIX_ADDR16 or others. Or change the format of DUMP_PREFIX_ADDRESS >> from "%p" to "%px",Or add DUMP_PREFIX_RAWADDR. Or keep the status quo. > > Linus quite likely will dislike (with passion) the idea of using %px.
OK, thanks.
> . >
-- Regards, Zhen Lei
| |