lkml.org 
[lkml]   [2023]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 2/2] hexdump: add a new dump prefix DUMP_PREFIX_CUSTOM
From
Date


On 2023/8/16 11:34, Sergey Senozhatsky wrote:
> On (23/08/16 11:20), Leizhen (ThunderTown) wrote:
>>> IMHO, this is pretty bad interface.
>>>
>>> + From the user POV:
>>>
>>> It is far from clear what values will be passed for the given
>>> printf format. It can be docummented but...
>>>
>>>
>>> + From the security POV:
>>>
>>> The compiler could not check if the printk() parameters
>>> match the format. I mean if the number of types of
>>> the parameters are correct.
>>
>> Yes, it has these problems. So, back to v2, how about add DUMP_PREFIX_ADDRESS_LOW16?
>> Or named DUMP_PREFIX_ADDR16 or others. Or change the format of DUMP_PREFIX_ADDRESS
>> from "%p" to "%px",Or add DUMP_PREFIX_RAWADDR. Or keep the status quo.
>
> Linus quite likely will dislike (with passion) the idea of using %px.

OK, thanks.

> .
>

--
Regards,
Zhen Lei

\
 
 \ /
  Last update: 2023-08-16 08:34    [W:0.048 / U:0.496 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site