lkml.org 
[lkml]   [2023]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 2/2] hexdump: add a new dump prefix DUMP_PREFIX_CUSTOM
On (23/08/16 11:20), Leizhen (ThunderTown) wrote:
> > IMHO, this is pretty bad interface.
> >
> > + From the user POV:
> >
> > It is far from clear what values will be passed for the given
> > printf format. It can be docummented but...
> >
> >
> > + From the security POV:
> >
> > The compiler could not check if the printk() parameters
> > match the format. I mean if the number of types of
> > the parameters are correct.
>
> Yes, it has these problems. So, back to v2, how about add DUMP_PREFIX_ADDRESS_LOW16?
> Or named DUMP_PREFIX_ADDR16 or others. Or change the format of DUMP_PREFIX_ADDRESS
> from "%p" to "%px",Or add DUMP_PREFIX_RAWADDR. Or keep the status quo.

Linus quite likely will dislike (with passion) the idea of using %px.

\
 
 \ /
  Last update: 2023-08-16 05:40    [W:0.059 / U:0.164 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site