Messages in this thread | | | Date | Wed, 16 Aug 2023 11:51:13 +0200 | From | Wolfram Sang <> | Subject | Re: [PATCH v3 RESEND 2/2] PCI: rcar-host: add support for optional regulators |
| |
On Thu, Jul 13, 2023 at 10:34:01AM -0500, Bjorn Helgaas wrote: > On Wed, Jul 12, 2023 at 12:39:16PM +0200, Wolfram Sang wrote: > > The KingFisher board has regulators. They just need to be en-/disabled, > > so we can leave the handling to devm. Order variables in reverse-xmas > > while we are here. > > > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > Krzysztof or Lorenzo may fix this up for you, but: > s/add support/Add support/ in subject to match history > and recast commit log to say what the patch *does* ("enable optional > regulators using devm, so devm will automatically disable them when > the driver releases the device"), not *what needs to be done*.
I will fix the commit messages and resend. But frankly, except the latter is a tad more explicit, they both qualify for "what needs to be done" for me *shrug* Still, thanks for the review, I appreciate it!
[unhandled content-type:application/pgp-signature] | |