Messages in this thread | | | Date | Wed, 16 Aug 2023 11:46:02 +0200 | Subject | Re: [PATCH] i2c: designware: add support for pinctrl for recovery | From | Yann Sionneau <> |
| |
Le 11/08/2023 à 16:36, Andy Shevchenko a écrit :
> On Fri, Aug 11, 2023 at 03:52:01PM +0200, Yann Sionneau wrote: >> From: Yann Sionneau <ysionneau@kalray.eu> >> >> Currently if the SoC needs pinctrl to switch the scl and sda > SCL > SDA ack > >> from hw function to gpio function, the recovery won't work. > from the I2C > > GPIO ack >> #include <linux/pm_runtime.h> >> #include <linux/regmap.h> >> #include <linux/reset.h> >> +#include <linux/pinctrl/consumer.h> > Keep this in order. Ok > > ... > >> + rinfo->pinctrl = devm_pinctrl_get(dev->dev); >> + if (!rinfo->pinctrl || IS_ERR(rinfo->pinctrl)) { > It's not possible to have it NULL, why a dead code?
Woops, I thought NULL was possible, you are right: it's impossible.
I will also add handling of -EPROBE_DEFER error.
Thanks for the review.
Regards,
--
Yann
| |