Messages in this thread | | | Date | Fri, 11 Aug 2023 17:36:44 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH] i2c: designware: add support for pinctrl for recovery |
| |
On Fri, Aug 11, 2023 at 03:52:01PM +0200, Yann Sionneau wrote: > From: Yann Sionneau <ysionneau@kalray.eu> > > Currently if the SoC needs pinctrl to switch the scl and sda
SCL SDA
> from hw function to gpio function, the recovery won't work.
from the I2C
GPIO
> scl-gpio = <>; > sda-gpio = <>; > > Are not enough for some SoCs to have a working recovery. > Some need: > > scl-gpio = <>; > sda-gpio = <>; > pinctrl-names = "default", "recovery"; > pinctrl-0 = <&i2c_pins_hw>; > pinctrl-1 = <&i2c_pins_gpio>; > > The driver was not filling rinfo->pinctrl with the device node > pinctrl data which is needed by generic recovery code.
...
> #include <linux/pm_runtime.h> > #include <linux/regmap.h> > #include <linux/reset.h> > +#include <linux/pinctrl/consumer.h>
Keep this in order.
...
> + rinfo->pinctrl = devm_pinctrl_get(dev->dev); > + if (!rinfo->pinctrl || IS_ERR(rinfo->pinctrl)) {
It's not possible to have it NULL, why a dead code?
> + rinfo->pinctrl = NULL; > + dev_info(dev->dev, "can't get pinctrl, bus recovery might not work\n"); > + }
-- With Best Regards, Andy Shevchenko
| |