Messages in this thread | | | From | Bartosz Golaszewski <> | Date | Tue, 15 Aug 2023 20:45:49 +0200 | Subject | Re: [PATCH] gpio: sim: replace memmove() + strstrip() with skip_spaces() + strim() |
| |
On Tue, Aug 15, 2023 at 12:34 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > On Sat, Aug 12, 2023 at 08:57:48PM +0200, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > > > Turns out we can avoid the memmove() by using skip_spaces() and strim(). > > We did that in gpio-consumer, let's do it in gpio-sim. > > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > ... > > > + strim(trimmed); > > > > - return dup; > > + return trimmed; > > Can be also > > return strim(trimmed); > > If it's only about \n replacement, then > > return strreplace(trimmed, '\n', '\0');
No, the user is free to pass all kinds of whitespaces after the string. I'll queue it with the above change. Thanks.
Bart
> > would work and in the next release be changed to kstrdup_and_replace(). > > > } > > -- > With Best Regards, > Andy Shevchenko > >
| |