Messages in this thread | | | Date | Tue, 15 Aug 2023 13:34:12 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH] gpio: sim: replace memmove() + strstrip() with skip_spaces() + strim() |
| |
On Sat, Aug 12, 2023 at 08:57:48PM +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > Turns out we can avoid the memmove() by using skip_spaces() and strim(). > We did that in gpio-consumer, let's do it in gpio-sim.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
...
> + strim(trimmed); > > - return dup; > + return trimmed;
Can be also
return strim(trimmed);
If it's only about \n replacement, then
return strreplace(trimmed, '\n', '\0');
would work and in the next release be changed to kstrdup_and_replace().
> }
-- With Best Regards, Andy Shevchenko
| |